Repository navigation
Conversation
Al-assad
marked this pull request as ready for review
November 4, 2026 07:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core ConfigMap watch stored only one DorisCluster per ConfigMap, so reconciling a second cluster overwrote the first reference. The same mutable map was written by reconciliation and read by informer callbacks.
Replace it with a cache field index of the current core ConfigMap references. Enqueue all referencing clusters in the ConfigMap's namespace when contents change, and let index updates remove stale references when a CR changes, disables automatic restart, or is deleted. The existing EnableRestartWhenConfigChange option remains required.
Validation:
QA validation passed with
selectdb/doris-operator:26.1.0-rc04: two healthy DCRs shared fe-config with automatic restart enabled; a real FE configuration change restarted both referencing FE Pods and returned both to Ready in 82.201s. BE and CN Pod UIDs were unchanged. No new restart policy or CRD field is introduced.