Repository navigation
Conversation
Al-assad
force-pushed
the
fix/service-live-state-reconcile
branch
from
November 4, 2026 07:06
10434b8 to
df8c3b4
Compare
Al-assad
marked this pull request as ready for review
November 4, 2026 07:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service comparison trusted a cached desired-state hash, so changes to the live selector, ports, type, or managed metadata could be ignored. It also omitted explicitly configured loadBalancerIP and other fields constructed by the operator.
Compare normalized live managed fields instead. Retain API defaults, allocated ClusterIP/NodePort values, unspecified cloud addresses, and externally added metadata. Patch from the current Service with optimistic locking so false/empty managed values are corrected without replacing allocated fields. Hash annotations remain informational and no longer prove equality.
Validation:
QA validation passed with
selectdb/doris-operator:26.1.0-rc06: an existing DDC FE Service retained its old hash while selector, target port, affinity, and publishNotReadyAddresses were changed. Reconciliation repaired all fields in 15.936s, preserving Service UID, ClusterIP, external annotations, workload Pod UIDs, and CR generation. This PR preserves unspecified LoadBalancerIP rather than taking ownership of a cloud-assigned address. Resource ownership protection is submitted separately in #542 and should land before broad drift reconciliation.