Repository navigation
fix(registry): add millisecond timestamp to instance metadata - #3807
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3807 +/- ##
============================================
+ Coverage 46.76% 58.72% +11.95%
============================================
Files 295 492 +197
Lines 17172 40433 +23261
============================================
+ Hits 8031 23744 +15713
- Misses 8287 14910 +6623
- Partials 854 1779 +925 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes #3804
dubbo-go does not write
timestampinto the instance metadata, so Dubbo Admin cannot read a register time and shows dubbo-go instances asUnRegistered.This PR writes
timestampincreateInstance, in milliseconds. Admin parses it withtime.UnixMilliand Dubbo Java writes milliseconds, so a value in seconds would show up in Admin as a 1970 date. Only this field uses milliseconds; other timestamps in dubbo-go stay in seconds.Verified end to end with Nacos application-level discovery and Dubbo Admin (develop):
timestamp,registerStateisUnRegisteredandregisterTimeis empty.timestamp=1794496237887,registerStateisRegisteredandregisterTimeis the current time.The test checks that the written
timestampis in milliseconds and falls between the times taken before and after registration.Checklist
developmake fmtto format my codemake testto run local tests