Repository navigation
ci: standardize RustFS setup across Iceberg repos - #3279
Merged
kevinjqliu merged 2 commits intoOct 26, 2026
Merged
Conversation
Set RUSTFS_OBS_LOG_STDOUT_ENABLED=true on the object-store service so that docker logs shows RustFS output, aligning with the canonical RustFS 1.0.0 setup used across Apache Iceberg repos. Generated-by: GitHub Copilot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review comments; the change is focused and low risk.
Review effort: Lite
Findings: None
What changed in this PR
Enables RustFS stdout logging in the shared Docker Compose fixture to improve CI failure diagnostics.
Changes:
- Adds
RUSTFS_OBS_LOG_STDOUT_ENABLED=trueto the RustFS service.
| File | Summary |
|---|---|
dev/docker-compose.yaml |
Enables RustFS stdout logging. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kevinjqliu
marked this pull request as draft
September 25, 2026 04:17
comphead
approved these changes
Sep 25, 2026
comphead
left a comment
comphead
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @kevinjqliu this is good observation
Bump rustfs/rustfs to 1.0.3 for both object-store and create-buckets, set RUSTFS_CONSOLE_ENABLE=false, and stop publishing port 9001, aligning with the RustFS setup used across Apache Iceberg repos. Generated-by: GitHub Copilot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
changed the title
kevinjqliu
commented
Oct 20, 2026
| environment: | ||
| - RUSTFS_ACCESS_KEY=admin | ||
| - RUSTFS_SECRET_KEY=password | ||
| - RUSTFS_OBS_LOG_STDOUT_ENABLED=true |
| - RUSTFS_ACCESS_KEY=admin | ||
| - RUSTFS_SECRET_KEY=password | ||
| - RUSTFS_OBS_LOG_STDOUT_ENABLED=true | ||
| - RUSTFS_CONSOLE_ENABLE=false |
Contributor
Author
There was a problem hiding this comment.
removes console port 9001, we dont need it
kevinjqliu
marked this pull request as ready for review
October 20, 2026 18:20
blackmwk
approved these changes
Oct 26, 2026
blackmwk
left a comment
blackmwk
left a comment
Contributor
There was a problem hiding this comment.
Thanks @kevinjqliu for this pr!
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Standardizes the RustFS setup across the Iceberg repos. Same change in:
The setup:
rustfs/rustfs:1.0.3, the latest stable./health/ready./healthis just liveness and can pass before storage and IAM are ready, so bucket creation can race it.RUSTFS_OBS_LOG_STDOUT_ENABLED=true. Otherwisedocker logsis empty.RUSTFS_CONSOLE_ENABLE=falseand no port 9001. Nothing uses the console.Are these changes tested?
Ran
docker compose configand startedrustfs/rustfs:1.0.3with the new config:/health/readyreturns 200 and logs show up indocker logs.AI Disclosure
Implemented with GitHub Copilot.