Repository navigation
Configure Doxia parsers per document - #1346
Open
slachiewicz wants to merge 9 commits into
Open
slachiewicz wants to merge 9 commits into
slachiewicz wants to merge 9 commits into
Conversation
This leverages PlexusConfigurator under the hood
Wire the configurator into site:auto-refresh, keep it open for the lifetime of site:run and site:auto-refresh instead of closing it before the rendered contexts are used, declare plexus-classworlds, and set @SInCE to 3.23.0.
The id comparison was inverted, so a configuration applied to every parser except the one it named. The patterns element is consumed by the configurator and must not be handed to the parser, which rejects it as an unknown property.
Configures markdown for a directory pattern and xdoc for all files and checks in the rendered pages that only the matching files change.
Rewrite the parameter javadoc to the element layout the plugin accepts, and add a short example page.
A regex: pattern sees the platform's separator, so the test failed on Windows. The docs now say so.
On macOS the regex PathMatcher compiles with Pattern.CANON_EQ, and JDK 8 cannot parse [/\\] followed by an escaped character under that flag (Unclosed character class). An alternation matches either separator everywhere.
slachiewicz
force-pushed
the
carry-msite-1000
branch
from
November 4, 2026 12:11
9ab5423 to
263c557
Compare
The user documentation lives in the site guide; the parameter documentation keeps the details.
slachiewicz
marked this pull request as ready for review
November 4, 2026 16:17
…uration Doxia shares one parser instance between files, so a property set for an earlier file stayed set for the next file of the same parser id. emitComments and emitAnchorsForIndexableEntries now start from the Site Plugin defaults for every configured file; the parameter documentation says other properties persist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries #177 by @kwin onto the 3.x line: his commit as authored, then our commits on top. Adds the
parserConfigurationsparameter tosite:site,site:runandsite:auto-refresh, which configures a Doxia parser per parser id and, optionally, per file pattern (glob:orregex:, matched against the absolute path). The first matching configuration wins.On top of the carried commit:
site:auto-refresh. The configurator now stays open for as long assite:runserves pages.ParserConfigurationKey.matcheswas inverted, so a configuration applied to every parser except the one it named.<patterns>element is no longer passed to the parser, which rejected it as an unknown property.emitCommentsandemitAnchorsForIndexableEntriesonly for files without a matching configuration. The configurator now resets both to the Site Plugin defaults before applying a configuration; any other property a configuration does not set keeps the value left by the previous file of the same parser id, which the parameter documentation states.MSITE-1000IT. The user documentation goes to the site guide, Document the configuration of Doxia parsers in the site guide maven-site#1809; the plugin site links to it, and the parameter documentation keeps the details.Not included: a
*wildcard parser id, which was left out in the #177 review.Please merge with "Rebase and merge" to keep Konrad as the author of his commit.
Fixes #1121
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
check one of the following: