[iceberg] Keep tables loadable when the mirror cannot publish their schema - #10187
Open
plusplusjiajia wants to merge 5 commits into
Open
plusplusjiajia wants to merge 5 commits into
plusplusjiajia wants to merge 5 commits into
Conversation
plusplusjiajia
marked this pull request as draft
September 26, 2026 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The Iceberg publication rules in
validateTableSchemaalso run when a table is loaded, so a table an older release let the mirror publish, such as one with aTIMESTAMP(9)column, cannot be loaded at all after upgrading: reads fail, and even theALTERthat turns the mirror off, which the error message itself recommends, fails because the catalog loads the table first. Loading now validates the table without its mirror option, so the table can be read and repaired, while persisting a schema, enabling the mirror, every commit and every retry still run the rules before anything is published. This does not repair Iceberg metadata an older release already wrote with such a type; turning the mirror off remains the way out. The rules came in with #9455 and #9467, which are already onrelease-2.1, so this should be cherry-picked there too.Tests
IcebergCompatibilityTest#testExistingTableWithUnpublishableTimestampsStillLoads,#testRetryRefusesToRepublishWhatTheMirrorCannotPublish