Read AI agent record times to the second, as Session Data defines them - #14112
Merged
Merged
Conversation
The conversation module read a record's time with java.time's ISO_OFFSET_DATE_TIME, which also takes a time without seconds, such as 2026-01-01T00:00Z. Session Data defines a time as a four-digit year, the letter T, the time of day to the second with a fraction of up to nine digits or none, and Z or an offset such as +08:00, and a value that is not such a time means the record has no time. The AI Sessionizer reads it that way, so the two ordered such records differently. Times now reads exactly that form. The documents of 94 real conversations are unchanged.
wankai123
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read AI agent record times to the second, as Session Data defines them
A review of #14108 against the AI Sessionizer found that the conversation module read a record's time with java.time's
ISO_OFFSET_DATE_TIME, which also takes a time without seconds, such as2026-01-01T00:00Z. Session Data defines a time as a four-digit year, the letter T, the time of day to the second with a fraction of up to nine digits or none, and Z or an offset such as+08:00; a value that is not such a time means the record has no time. The Sessionizer reads it that way, so the two ordered such records differently.format/Times.javareads exactly that form, with a strict formatter.New test
SessionFormatsTest.onlyATimeTheFormatDefinesIsATime: three valid times and eight values that are no time (no seconds, a five-digit year, an offset without a colon, a lowercaset, hour 24, ten fraction digits, February 30). It fails with the ISO reader back.The module's 100 tests pass, with checkstyle. The documents of 94 real conversations (65 Claude Code, 8 with MCP calls, 21 LangChain) are byte-identical before and after.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
Update the
CHANGESlog.