Repository navigation
Fix: Handle large reverse-search limits without integer overflow - #347
Merged
ashvardanian merged 1 commit intoOct 18, 2026
Merged
Conversation
grouville
changed the title
grouville
force-pushed
the
fix-reverse-search-overflow
branch
from
October 8, 2026 09:05
b36fd74 to
b8a2c04
Compare
ashvardanian
force-pushed
the
fix-reverse-search-overflow
branch
2 times, most recently
from
October 18, 2026 21:27
8e118a9 to
9569caf
Compare
Guard reverse-search bounds before addition to prevent unsigned overflow. Consolidate the boundary and empty-search regressions in the shared STL compatibility tests.
ashvardanian
force-pushed
the
fix-reverse-search-overflow
branch
from
October 18, 2026 21:34
9569caf to
3aa6ae8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard reverse-search bounds before addition so large positions cannot wrap.
Consolidate the overflow regressions and the recently merged empty-search checks in the existing STL compatibility tests, which exercise both standard-library and StringZilla string types.
Validation: the STL read tests pass in C++11 and C++20. Rebased onto current main-dev to resolve the conflict.