Repository navigation
Fix: Return no match for forward searches past the string end - #348
Merged
ashvardanian merged 2 commits intoOct 24, 2026
Merged
Conversation
grouville
force-pushed
the
fix-forward-search-bounds
branch
from
October 8, 2026 09:05
3e1a636 to
a61c56c
Compare
grouville
changed the title
grouville
force-pushed
the
fix-forward-search-bounds
branch
from
October 19, 2026 18:40
a61c56c to
eb3190b
Compare
ashvardanian
force-pushed
the
fix-forward-search-bounds
branch
from
October 24, 2026 22:39
9f0ff10 to
10aaf21
Compare
A starting position past the end of a string reached unchecked pointer arithmetic in forward searches. They now return `npos` first, including for an empty needle, as `std::string::find` does, and the string and view methods document that bound.
The installer's latest-release lookup produced "{" as the version, so
no runner was installed while the step still passed, and the failure
only surfaced once Cargo ran the tests. Install v49.0.3 explicitly and
check the executable right away, so a failed download fails the step.
ashvardanian
force-pushed
the
fix-forward-search-bounds
branch
from
October 24, 2026 22:48
10aaf21 to
96413cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make forward searches return
npos(no match) when their starting position is past the end of the text, as requested in #275. These inputs previously fell outside the documented contract and could reach unchecked pointer calculations.For example, searching
"abc"from position4now returns no match, including when the search string is empty. Searches starting exactly at the end keep their existing behavior.Add three checks in the shared search functions, update their documentation, and extend the existing tests for empty strings, ordinary strings, and extreme starting positions.
The branch is refreshed on
main-dev. A separate CI commit pins Wasmtime to v49.0.3: the installer's latest-release lookup returned an invalid version in the first refreshed run. Installation is now checked before running the WebAssembly tests.C++11 and C++20 search tests pass with address, undefined-behavior, and leak sanitizers. The core Python suite also passes locally with memory diagnostics enabled: 10,622 passed and 51 optional checks skipped. All 62 GitHub checks pass on the refreshed
main-devbranch.