Repository navigation
fix: generate native SQLite registered query value types - #59
Merged
Merged
Conversation
smiggleworth
added a commit
that referenced
this pull request
Oct 13, 2026
* docs: require a changelog section with every version bump * ci: drop the redundant main-branch check from the publish workflow (#52) Publishing runs in the npm environment, which now only deploys from main, so the workflow no longer needs its own GITHUB_REF check. * Contract ORM API and preserve migration scripts and failed cleanup (#56) * feat: contract ORM API and recover failed migration cleanup * fix: guard migration lifetimes and load project entries by file URL * ci: preserve the required package check across platform gates * fix: qualify real PostgreSQL generation and validation (#57) * fix: generate native SQLite registered query value types (#59) * chore(release): prepare ORM 0.5.0 from current develop (#60) * docs: refresh ORM 0.5.0 qualification status (#61)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated SQLite registered queries declared numeric/bigint results as strings and boolean results as JavaScript booleans, although the adapter returns native numbers. A real
typed(n numeric,b bigint,flag boolean)query returns{n:1.25,b:42,flag:1}; the same columns also accept text, blobs, and null under SQLite's dynamic storage rules.Generate SQLite row fields as
number | string | Uint8Array | null, covering native adapter values for declared columns and expressions without adding runtime coercion. Document field narrowing and integer read limits, and retain PostgreSQL's standard parser mapping.Validation:
npm run fmt -- --checkandnpm run checkpass (71 unit tests; coverage, type checks, packed contracts, build, benchmark gate, publint, pack dry run).npm run test:integrationpasses all 30 tests against an isolated local PostgreSQL 18.6 cluster, with explicit numeric-string/boolean parser parity coverage.Callers must regenerate artifacts and narrow SQLite result fields before using one value type. This addresses generated registered-query rows; it does not change schema DSL decoding or opt into bigint reads.