Repository navigation
Conversation
github-actions
Bot
added
area/datastore
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tstirrat15
previously approved these changes
Nov 4, 2026
| engine := testdatastore.RunPostgresForTesting(t, postgresTestVersion(), false) | ||
| uri := engine.NewDatabase(t) | ||
| ctx, cancel := context.WithCancel(t.Context()) | ||
| defer cancel() |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After a PostgreSQL restart or failover, a heartbeat follower can repeatedly retry election on a closed connection and never become leader without restarting SpiceDB.
Acquire a connection for each election attempt and release it when unsuccessful, allowing the pool to replace closed connections. Existing heartbeat writes and retry timing are preserved.
Testing
Added a regression test that terminates a follower’s election connection and verifies that it reconnects, acquires leadership, and resumes heartbeats. The test fails before the fix and passes afterward with the race detector:
Also verified recovery using two local SpiceDB instances and PostgreSQL 16 in Docker, testing both follower connection termination and a database restart.