Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
An EKS cluster can report
ACTIVEbefore the DNS record for its API server endpoint resolves. E2E setup creates the pod identity service account right after the cluster becomesACTIVE. When the endpoint doesn't resolve yet, the request fails withno such host, and the existing retry gives up after about 30 seconds:This change makes
hybridCluster.create()wait until the API server hostname resolves before it returns. It polls every 10s, for up to 10 minutes. Every caller ofcreate()therefore gets a cluster whose endpoint can be reached, instead of each Kubernetes call needing its own DNS retries.Testing (if applicable):
waitForAPIServerDNS:localhost).invalid, reserved by RFC 6761), which times out with an error naming the hostgo build ./...andgo vet ./test/e2e/...pass.Waiting for API server endpoint to resolvefollowed byAPI server endpoint resolved.Documentation added/planned (if applicable):
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.