Skip to content

SDK does not handle request exceptions #144

Description

@ejohnso49

When the SDK makes requests to the Balena API, it will not catch exceptions raised by the requests package. These exceptions then bubble up to the SDK client. I think it would be nice for the SDK to catch these and return something to the client to indicate the operation failed instead of not handling the exception. The instance I encountered was a call with balena.models.supervisor.reboot() resulting in a requests.exceptions.ReadTimeout.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions