Repository navigation
Conversation
Now handles \imap_errors() returning false. Addresses/avoids barbushin#671
…ction is already closed * Issue barbushin#680: Fix ValueError for `imap_ping()`, when the connection is already closed
Prevent TypeError while constructing ConnectionException.
Update master branch to current 6.x code base
|
Could be merged? @Sebbo94BY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes landed on the
masterbranch but are never added to a release branch (e.g.5.xand6.x).The missing bugfixes are:
IMAP\Connection is already closed#680 #690I discovered this because I still encountered issue #680 (
Uncaught ValueError: IMAP\Connection is already closed) in v5.1.0 and noticed the change from PR #690 was missing.Merging main into the
6.xbranch fixes this. Can you please perform a release after merging this PR? This will prevent me for needing to fix this in our own codebase.