Repository navigation
junos_bgp_cluster_length_before_originator_id: drop fixed batfish#10370 from sickbay reason - #240
Merged
Merged
Conversation
…70 from sickbay reason batfish/batfish#10371 models `path-selection compare-cluster-length-before-originator-id`, and Batfish now selects path A in the KNOB virtual-router, matching the device. test_bgp_rib_routes[dut] still fails because JunosValidator drops Batfish's iBGP routes in non-default VRFs before matching, so the sickbay entry now cites only #239. Refresh the README's Batfish notes. ---- Prompt: ``` merged the labvalidation PR and the batfihs OSS fix ```
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
=======================================
Coverage 83.59% 83.59%
=======================================
Files 96 96
Lines 4706 4706
=======================================
Hits 3934 3934
Misses 772 772
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batfish/batfish#10371 models
path-selection compare-cluster-length-before-originator-id, and Batfish now selectspath A in the KNOB virtual-router, matching the device.
test_bgp_rib_routes[dut] still fails because JunosValidator drops
Batfish's iBGP routes in non-default VRFs before matching, so the
sickbay entry now cites only #239. Refresh the
README's Batfish notes.
Prompt: