Skip to content

ci: wait for Batfish readiness before running lab tests - #241

Merged
dhalperi merged 1 commit into
mainfrom
ci-wait-for-batfish
Oct 1, 2026
Merged

dhalperi merged 1 commit into
mainfrom
ci-wait-for-batfish

Conversation

@dhalperi

@dhalperi dhalperi commented Oct 1, 2026

Copy link
Copy Markdown
Member

Replace fixed startup sleeps with an endpoint readiness probe. Fail
early when the Batfish process or container exits before becoming ready.


Prompt:

Build keeps failing on batfish not launched. Can we make the launchng process more robust? https://github.com/batfish/lab-validation/actions/runs/36918043504/job/110557367647#step:9:945

Replace fixed startup sleeps with an endpoint readiness probe. Fail
early when the Batfish process or container exits before becoming ready.

----

Prompt:
```
Build keeps failing on batfish not launched. Can we make the launchng process more robust? https://github.com/batfish/lab-validation/actions/runs/36918043504/job/110557367647#step:9:945
```
@dhalperi
dhalperi enabled auto-merge (squash) October 1, 2026 21:34
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.59%. Comparing base (9f01e12) to head (27787fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files          96       96           
  Lines        4706     4706           
=======================================
  Hits         3934     3934           
  Misses        772      772           
Flag Coverage Δ
unittests 83.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhalperi
dhalperi merged commit a5bf02f into main Oct 1, 2026
147 checks passed
@dhalperi
dhalperi deleted the ci-wait-for-batfish branch October 1, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants