Misc cleanup (review by David) #104

Activity

1. ounsworth commented on Sep 8, 2026

   

   ounsworth

   on Sep 8, 2026

   ContributorAuthor

   More actions

   David had suggested:

   • Move all the name str's into the Factory crate.

   Currently, each algorithm struct is required to give itself a name in order to impl the Algorithm trait:

   /// Metadata about a cryptographic algorithm.
   pub trait Algorithm {
       /// String name for the algorithm, used consistently across the library.
       const ALG_NAME: &'static str;
       /// Maximum security strength supported by the algorithm.
       /// In other words, this algorithm can produce outputs up to this security strength,
       /// but may produce outputs with lower security strength, for example, if asked to truncate.
       const MAX_SECURITY_STRENGTH: SecurityStrength;
   }

   At the moment, I think Factory is the only thing that consumes these string names, but my intuition is to leave this the way it is because other things beyond Factory could use these in the future.

   So: Won't Fix

   👍React with 👍1Reacted by Nikola Pajkovsky