Skip to content

Fix published v12 declaration compatibility - #300

Open
bcomnes wants to merge 1 commit into
masterfrom
bret/fix-v12-declaration-consumer
Open

Fix published v12 declaration compatibility#300
bcomnes wants to merge 1 commit into
masterfrom
bret/fix-v12-declaration-consumer

Conversation

@bcomnes

@bcomnes bcomnes commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Emit valid concrete HTML and Markdown builder declarations without an undeclared generic.
  • Replace implementation-derived copy report and logger types with local structural contracts.
  • Add a packed-tarball consumer test covering root and public type imports under TypeScript 5.9 and 6.0 with NodeNext resolution and skipLibCheck: false.
  • Clean generated declaration artifacts after the packed-consumer test.

Validation

  • npm test
  • The packed artifact installs and compiles in a clean consumer under TypeScript 5.9 and 6.0.

Fixes #291.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 34011220579

Coverage increased (+0.1%) to 94.297%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: 28 of 28 lines across 6 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 7324
Covered Lines: 7098
Line Coverage: 96.91%
Relevant Branches: 1706
Covered Branches: 1417
Branch Coverage: 83.06%
Branches in Coverage %: Yes
Coverage Strength: 182.52 hits per line

💛 - Coveralls

@bcomnes
bcomnes marked this pull request as ready for review September 6, 2026 04:39
Comment thread lib/build-copy/index.js

/**
* @typedef {Record<string, Awaited<ReturnType<typeof copy>>>} CopyBuilderReport
* @typedef {Record<string, object>} CopyBuilderReport

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we losing type resolution here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Published v12 declarations fail strict consumer type-checking

2 participants