fix: deduplicate PostgreSQL latest-file upserts - #104
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Deduplicates PostgreSQL latest-file upserts to prevent conflicting updates within a batch.
Changes:
- Groups latest files by collector and data type.
- Retains only the newest observation before batched upserts.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(collector_id, data_type)latest-file key before issuing the batched upsertFailure mode
The PostgreSQL backend used one
INSERT ... ON CONFLICT DO UPDATEstatement for each 1,000-item batch. A crawl can contain multiple rows with the same(collector_id, data_type), and PostgreSQL rejects an upsert that would update its target row twice in one statement.Validation
cargo build --verbosecargo build --features cli --verbosecargo test --no-default-features --verbosecargo clippy --all-features -- -D warnings