fix(backup): gate retries on last attempt, add bounded upload backoff - #108
Merged
Merged
Conversation
Fixes #107. The periodic backup gate advanced only on success, so a failed S3 upload re-ran the full-file backup on every update tick. Track the last attempt instead, and retry the upload step up to 3 times with exponential backoff before waiting out the interval window.
digizeph
enabled auto-merge (rebase)
August 30, 2026 04:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107.
The periodic backup gate advanced
last_backup_timeonly on success, so once an S3 upload failed, every update tick started a new attempt that re-uploaded the entire file from byte zero. With a multi-gigabyte database this loops indefinitely and never succeeds.Changes:
BGPKIT_BROKER_BACKUP_INTERVAL_HOURSwindow before the next try.Not addressed here (possible follow-ups from #107): compressing the backup before upload, resumable multipart upload, and a failure-side heartbeat.