Repository navigation
Bump block/buzz to pick up messages search --before - #3362
Draft
tmellor-block wants to merge 1 commit into
Draft
tmellor-block wants to merge 1 commit into
tmellor-block wants to merge 1 commit into
Conversation
Move the buzz-audio-client pin, which also selects the bundled buzz CLI revision, from c8d736642e1c to 0e6037c74d67 (block/buzz#9382). The bundled CLI gains `messages search --before` and `--before-id` for paging back through an author's messages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tim Mellor <117199716+tmellor-block@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Moves the
block/buzzpin fromc8d736642e1cto0e6037c74d67(block/buzz#9382). That one pin, thebuzz-audio-clientgit dependency insrc-tauri/Cargo.toml, also picks the revision thatscripts/build-buzz-cli.mjsbuilds the bundledbuzzCLI from. So the bundled CLI gainsbuzz messages search --beforeand--before-id, for paging back through an author's messages.The diff is two lines: the rev in
src-tauri/Cargo.tomland the matchingsourceline inCargo.lock. Nothing else in the lock file moves, and--lockedbuilds accept it.What the bump brings in
The range has 88 block/buzz commits. Only two things from block/buzz ship in Buzz Desktop: the
buzz-audio-clientcrate and the bundledbuzzCLI, plus the in-repo crates it builds with (buzz-core,buzz-sdk,buzz-ws-client,buzz-persona).Huddle audio client (
crates/buzz-audio-client, one change)User-Agent: buzz-audio-client/<version>when the caller didn't set one. Buzz Desktop sets no User-Agent on the audio socket (src-tauri/src/relay/huddle/audio.rs), so huddle audio connections now carry this header. No API change; the desktop code compiles unchanged.Bundled
buzzCLImessages search --before <unix ts>(sent as the filter'suntil) and--before-id <event id>(requires--before; resumes after that event so events from the same second aren't repeated or skipped).--before-idwith--queryis a usage error. Without the new flags the filter is unchanged.lsoflookup now caps its output and checks the exit status. CLI-side only: the desktop provider protocol is unchanged.messages editkeeps a message's attachments across successive edits, and adds--clear-attachments. It asks the relay for the current effective edit first. Against a relay without that lookup (added in Buzz Relay 0.3.0),messages editnow refuses with "upgrade the relay before editing" instead of dropping attachments.Not shipped in this app (no effect on Buzz Desktop)
Testing
Run by an agent on macOS (Apple Silicon):
cargo fmt --all --check: pass.cargo clippy --workspace --locked --all-targets -- -D warnings: pass.cargo test --manifest-path src-tauri/Cargo.toml --locked: 1121 + 24 passed, 0 failed, with 15 tests skipped for local reasons that have nothing to do with the bump. The 21relay::huddle::audiotests pass. Skipped: the media-conversion tests (media_preparation,converted_spool), because this machine's Homebrewffmpegcan't loadlibx265, andwindow_state::tests::onboarding_snapshot_is_kept_until_next_launch_restore, which crashes the test process (SIGSEGV) on this machine with the old pin too. CI runs the full suite on Linux.node scripts/test-buzz-cli.mjs(stages the CLI the way a desktop build does, then runs it): pass. The stagedbuzz messages search --helplists--beforeand--before-id.buzz auth desktop listwith the new CLI reports an existing pairing asaccepted. That path runs the new same-user socket check on macOS.--since … --before <now> --limit 5, then a second page with--before <last created_at> --before-id <last id>. Page 2 started right after page 1's last event, with no overlap and nothing newer than the cursor. The old CLI rejects--beforeas an unknown argument.Not tested:
relay::huddle::audiounit tests, not by a real call.buzz auth desktop pair), which needs a person to click Allow.messages editagainst a live relay (it writes).Note for local testing
scripts/build-buzz-cli.mjsshares one Cargo build directory (target/buzz-cli-build) across block/buzz revisions. Cargo treats git checkouts as unchanging, so after a rev bump it can reuse the old revision's CLI build and stage the old binary under the new rev's name. Ifsrc-tauri/resources/bin/buzz messages search --helpdoesn't list--beforeafterjust desktop, deletetarget/buzz-cli-buildandtarget/buzz-cli/0e6037c74d67930de36143ed4661f469039d8dc7in the main checkout and run it again. This PR doesn't change the script.🤖 Generated with Claude Code