Repository navigation
Remove Bonds backend requirement from MyData card creation - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the architecture introduced by PR #66: the product owner does not operate a Bonds signing backend. Remove the capabilities/App Attest preflight and the Release broker wiring specifically from MyData national-ID card issuance. Preserve review, explicit signing, retry, cancellation, secure PDF password entry and draft deallocation.
The existing direct TW FidO client requires SP credentials and remains development-only. Development now checks its local configuration before downloading identity data; Release accurately explains that direct card signing is not yet available, while MyData original-file vault imports remain independent and enabled. This does not embed shared SP secrets or treat MyData login as a signature on the Bonds card.
The unused broker capabilities endpoint from broker PR #9 was never deployed. Other pre-existing broker consumers (ZK/document signing/diagnostics) are outside this card-flow correction. No backend deployment or TestFlight publication is included. Official app-to-app integration is an application process: https://fido.moi.gov.tw/pt/agency . A distributable no-Bonds-backend integration still needs an officially supported credential arrangement.
Validation: 1,641 local Swift tests / 173 suites passed; first-card UI and both MyData vault UI tests passed; Release arm64 simulator build passed. CI is required before merge. See docs/mydata-first-card-flow.md for the corrected boundary.