Repository navigation
feat(content-sidebar): add isForcedToUseTemplates for sign - #4906
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe sidebar now hides the Box Sign navigation section when templates are forced, even if Box Sign is enabled. The sidebar props include the optional flag, and a test checks this rendering condition. ChangesBox Sign sidebar
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
Merge Queue Status
This pull request spent 13 minutes 20 seconds in the queue, including 12 minutes 32 seconds running CI. Required conditions to merge
|
What
Adds a new optional
isForcedToUseTemplatesproperty tosignSidebarProps. When true, the Box Sign entry point in the sidebar nav is suppressed, even if Box Sign is otherwise enabled.Why
Gives the consuming app fine-grained control to hide the Box Sign sidebar button in flows where users are forced to use templates.
How
isForcedToUseTemplates?: booleanto theSignSidebarPropsinterface (SidebarNavSign.tsx).SidebarNav.jsand updated the render gate fromhasBoxSign &&tohasBoxSign && !isForcedToUseTemplates &&.Testing
SidebarNavtest asserting the Box Sign button is not rendered whenisForcedToUseTemplates=truedespiteenabled=true.SidebarNavtests pass.Summary by CodeRabbit