Repository navigation
fix(registry): dashboard and Vanilla follow-ups from the theme review - #267
Merged
Merged
Conversation
… orders table The value axes ended on their own bounds, so the chart pulled the top and bottom labels about 12px inward, off the gridlines they name. Like the weekday axis, they now run half a step past each end and leave the bounds unlabelled; the overview's two charts use the same helper. A test checks that the revenue labels are evenly spaced. The overview's "Recent orders" table needed 560px and clipped its Amount column in the half-width card at a 1280px desktop; narrower fixed columns bring the minimum to 400. Vanilla's breadcrumb now ends a long section name with an ellipsis instead of cutting it off. The playground's preview notes that root-navigator overlays open over the whole window.
…okens
The import sorter joined lines with \n, so a CRLF template whose icon import
was swapped came out with mixed endings; it now reuses the file's own line
ending. An unsupported {{...}} token now says the registry may need a newer
remix_cli.
The state test now measures each state's fill against the rest fill and the border hairline (at least 1.05:1) instead of failing only on an exact match, and lists the near-collisions the reference makes too, each with a reason. The tab case sits on the muted list it is drawn on. The dark current tab's fill is input at 30% pre-blended over the muted list, so the decoration shadow beneath it no longer darkens it; the spec records the deviation. A Scaffold host case shows Material text follows the host's ThemeData, and the scope docs now say to give that ThemeData the scope's brightness. The spent spec phases, the pending skips, and VANILLA_SPEC_ALL are removed; every target still runs.
With room past each end, the Vanilla value labels already sat on their gridlines, but Fortal's taller axis label was still pulled about 4px inward at the top by `fitInside`. Dashboard charts on a padded value axis now turn `fitInside` off for that axis through a shared chart style; the preset chart recipes keep it, for charts whose axes end on their bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-ups from the review of #264 and #265, from
plans/2026-10-01-vanilla-stack-follow-ups.md(Parts 2–4).mutedlist, so its decoration shadow no longer darkens it (recorded as a deviation).Scaffoldhost test pins that Material text follows the host'sThemeData; the scope docs now say to give it the scope's brightness.VANILLA_SPEC_ALLare removed.{{...}}token suggests upgradingremix_cli.Decisions taken with the plan's defaults: the focus ring stays at shadcn's
ring/50(recorded deviation), and root-navigator overlays opening over the whole playground window are left as is (noted in the preview shell).Related Issues
None.
Checklist
registry_source1363 passed (before the axis test was re-added), Vanilla tests 392 passed,apps/playground24,apps/dashboard115,apps/demo61,remix_cli215, tool tests 68. Dogfood mirrors the registry.ci:checks,docs:check, format, and analysis. CI runs them.///).Breaking Change