node config options when client doesn't send them #127

Activity

1. imaginator commented on Sep 1, 2013

   

   imaginator

   on Sep 1, 2013

   Member

   More actions

   Good point. Sensible defaults should be added for any required params.

   On 30 August 2013 14:45, mikesouthron notifications@github.com wrote:

   When the client doesn't send in node config options the http api is
   sending nothing through to the server.

   For example, when the client does not send pubsub#access_model the api
   server doesn't send anything to the server.

   Ideally the API server should fill in any missing config options with a
   default.

   —
   Reply to this email directly or view it on GitHubhttps://github.com//issues/127
   .

   Simon Tennant | buddycloud.com | +49 17 8545 0880 | office hours:
   goo.gl/tQgxP
2. abmargb commented on Oct 24, 2014

   

   abmargb

   on Oct 24, 2014

   Collaborator

   More actions

   That kind of logic should live in the buddycloud-server instead.
3. abmargb

   closed this as completedon Oct 24, 2014
4. imaginator commented on Oct 24, 2014

   

   imaginator

   on Oct 24, 2014

   Member

   More actions

   @abmargb does the buddycloud-server do this?
5. abmargb commented on Oct 24, 2014

   

   abmargb

   on Oct 24, 2014

   Collaborator

   More actions

   There is a PR in place for this buddycloud/buddycloud-server-java#201, not ready yet though.