Repository navigation
Conversation
jrandolf
force-pushed
the
codex/native-sticky-directories
branch
from
September 30, 2026 20:22
06fd7ef to
bf954a9
Compare
jrandolf
marked this pull request as ready for review
September 30, 2026 20:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native workers request mode 0777 for action directories, input roots and temporary directories. Add
native.useStickyDirectoriesso deployments that run actions under another UID can request the sticky bit on those three directories. The default remains disabled, preserving actions that need to remove worker-owned inputs. Ordinary input/output subdirectories, server logs, readiness checks and the virtual backend retain their existing modes.Pass the selected mode through the shared-directory creator and local executor, and regenerate the configuration protobuf. Tests cover both modes, directory-creation failures and unaffected directories. The new expectations fail when directory creation uses the old fixed mode.
Both Go and Bazel dependencies now use upstream bb-storage 624be7d, the merged BSD sticky-bit fix from #382.
The bb-storage update also adopts its cache configuration change: local cache settings now use
keyLocationMap: { onBlockDevice: ..., maximumGetAttempts: ..., maximumPutAttempts: ... }instead of the three former top-level fields. Existing native-worker local cache configurations need that migration.Validation on the updated dependencies: native macOS builder tests with and without the race detector; worker and builder cross-builds for Linux amd64/arm64, Windows amd64 and FreeBSD amd64; upstream formatting, stable repeated generation and golint. FreeBSD was cross-compiled only. Native Unix permission and ACL semantics still apply; this option does not provide complete action isolation or change Windows access controls.
Integration tests using this PR and the canonical merged storage dependency passed on Linux (normal/race) and macOS. Real actions exercised omitted, false and true settings, the three selected directory modes, unchanged input/output and log-directory modes, and cleanup.
Fixes #269.