Skip to content

Fix wallet restore safety - #414

Merged
a1denvalu3 merged 4 commits into
mainfrom
fix/410-wallet-restore
Oct 23, 2026
Merged

a1denvalu3 merged 4 commits into
mainfrom
fix/410-wallet-restore

Conversation

@a1denvalu3

@a1denvalu3 a1denvalu3 commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Fix a security issue in wallet restoration. Closes #410.

Validation: 53 focused wallet, restore, onboarding, mnemonic, and recovery-backup tests passed; ./gradlew assembleDebug passed with JDK 25.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.96552% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.61%. Comparing base (d123f11) to head (06c15f9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ectricdreams/numo/core/cashu/CashuWalletManager.kt 74.11% 10 Missing and 12 partials ⚠️
...eams/numo/feature/onboarding/OnboardingActivity.kt 33.33% 10 Missing ⚠️
...s/numo/feature/onboarding/OnboardingMintAdapter.kt 71.42% 5 Missing and 1 partial ⚠️
...ams/numo/feature/settings/RestoreWalletActivity.kt 57.14% 6 Missing ⚠️
.../electricdreams/numo/core/prefs/PreferenceStore.kt 50.00% 4 Missing and 1 partial ⚠️
...a/com/electricdreams/numo/core/util/MintManager.kt 76.19% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #414      +/-   ##
============================================
+ Coverage     36.29%   37.61%   +1.31%     
- Complexity     2142     2222      +80     
============================================
  Files           241      241              
  Lines         26312    26432     +120     
  Branches       3741     3753      +12     
============================================
+ Hits           9551     9943     +392     
+ Misses        15525    15204     -321     
- Partials       1236     1285      +49     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1denvalu3
a1denvalu3 merged commit e0c89c0 into main Oct 23, 2026
8 checks passed
@a1denvalu3
a1denvalu3 deleted the fix/410-wallet-restore branch October 23, 2026 07:48
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Numo Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Restore overwrites wallet and recovery backup before validating the new seed

1 participant