Repository navigation
Retry pending Lightning mint quotes during swaps - #421
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
============================================
+ Coverage 37.66% 37.68% +0.02%
- Complexity 2230 2233 +3
============================================
Files 241 241
Lines 26432 26450 +18
Branches 3753 3755 +2
============================================
+ Hits 9955 9968 +13
- Misses 15197 15201 +4
- Partials 1280 1281 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a successful unknown-mint melt, the receiving Lightning mint may still report its quote as UNPAID or PENDING. Check the same quote up to five times, one second apart, before using the existing failure path. PAID and ISSUED proceed immediately, and coroutine cancellation stops the wait.
Quote-check errors and retry exhaustion retain the existing failure behavior.
Each retry test uses its own coroutine scheduler so timing assertions remain independent of other test classes.
Addresses #411.
Validation:
./gradlew testDebugUnitTest --tests "com.electricdreams.numo.payment.SwapToLightningMintManagerTest"— all 10 tests pass, covering delayed payment confirmation, issued quotes, retry exhaustion, errors, and cancellation.LightningMintHandlerTestandSwapToLightningMintManagerTesttogether — all 19 tests pass, verifying the retry tests remain isolated from a previously advanced main scheduler../gradlew jacocoTestReport assembleDebug --no-daemon --console=plain— the full unit suite, coverage report, and debug build pass.git diff --check— passes.