Repository navigation
Fix standalone example headers and tick dispatch - #219
Merged
Merged
Conversation
Member
Author
|
Windows exposed the same missing |
jcelerier
added a commit
to ossia/score
that referenced
this pull request
Oct 9, 2026
celtera/avendish#219 merged as 797b3c9d7e, so the ColorDisplay fix this branch needs is on main and the pin no longer has to name fix/color-display-unit-aliases. Pinned to main's tip a1f6471c53, which also picks up #220. Content is unchanged where it matters: the tree at the old pin and at 797b3c9d7e is byte-identical (`git diff` reports no files), and #220 on top touches one line -- a Catch2 tag inside `if(BUILD_TESTING)` in cmake/avendish.tests.cmake -- which score never evaluates. Note `git cherry` is useless for checking this: #219 was squash-merged, so its 7 commits collapsed into 1 and no patch-id matches. Compare trees, not commits. A pin on a feature branch dies when that branch is tidied up, which is why this matters beyond neatness. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019QYyvhRXvSMSRQPaq12Teq
jcelerier
added a commit
to ossia/score
that referenced
this pull request
Oct 9, 2026
celtera/avendish#219 merged as 797b3c9d7e, so the ColorDisplay fix this branch needs is on main and the pin no longer has to name fix/color-display-unit-aliases. Pinned to main's tip a1f6471c53, which also picks up #220. Content is unchanged where it matters: the tree at the old pin and at 797b3c9d7e is byte-identical (`git diff` reports no files), and #220 on top touches one line -- a Catch2 tag inside `if(BUILD_TESTING)` in cmake/avendish.tests.cmake -- which score never evaluates. Note `git cherry` is useless for checking this: #219 was squash-merged, so its 7 commits collapsed into 1 and no patch-id matches. Compare trees, not commits. A pin on a feature branch dies when that branch is tidied up, which is why this matters beyond neatness. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019QYyvhRXvSMSRQPaq12Teq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the example compilation and dispatch failures exposed by score CI and this PR's Avendish CI runs:
ossia/network/dataspace/dataspace_base_defs_fwd.hpp, which declaresossia::rgba8,ossia::rgba, and the other color value aliases.color.hppalone provides the unit tags, not those aliases. This completes the standalone-header fix from Release audit: categories, descriptions, licenses and help text #217.halp_metainvocations with ordinarystatic constevalmetadata methods, matching the other raw examples. Preserve the example's deliberately helper-free, standard-header-free design and restore the uninterruptedc_namecomment.halp::tick,halp::tick_musical, andhalp::tick_flickstypes as each example'stick. This lets host dispatch construct the correct tick instead of selecting an integer frame-count call. The dispatch static assertion remains intact.CI evidence
Minimal.hpp:23on the undefinedhalp_metainvocation.operator() cannot be called: if it takes a tick, declare using tick = <that type>; in the object.Verification
-std=c++20 -nostdinc -nostdinc++.get_tick_or_framesandinvoke_effectand verifies observable frames, tempo, and relative-position outputs.Native Windows/macOS CI has not yet completed for the updated revision. Existing example build targets cover these compilation failures; no dispatch guard was weakened and no new external dependency was added.
Follow-up CI repairs
process_adapterboundary, matching the existing audio-adapter behavior. This fixes the example host as well as CLAP/VST3/vintage callers without weakening dispatch assertions.Additional local verification: actual example host runs all three tick examples; patched Godot src/godot.cpp compiles; updated workflows pass actionlint. Native CI is running on the updated revision.
Standalone header/test follow-up
Remove an unused libossia value include from ArrayCombiner, include
<cstdlib>where SampleAccurateGeneratorExample callsstd::rand, and migrate ArrayBest tests to its existing event-driven optional-output contract. The complete array test executable passes 82 assertions in 7 cases; the generator compile/run smoke passes.Full local verification
A full default standalone build with the dependencies available locally passed after correcting the optional GLFW link guard in the Qt standalone path. All 299 configured CTest cases passed, including Godot runtime smoke tests. No backend enable flag was turned off for that build. Native CI remains the acceptance gate for platform-specific SDK coverage.
Restored local builders
Revision
43103bdcpassed all 23 checks. Revision07ec34d2restores the original local-builder workflows without changing the verified source fixes. Fresh checks on this revision remain pending; previous green checks are not claimed as verification of the restored routing.