Added numbered symlinks to build steps for ease of use - #2467
Open
craigcomstock wants to merge 6 commits into
Open
Added numbered symlinks to build steps for ease of use#2467craigcomstock wants to merge 6 commits into
craigcomstock wants to merge 6 commits into
Conversation
|
Thanks for submitting a pull request! Maybe @craigcomstock can review this? |
craigcomstock
force-pushed
the
ent-12599/master
branch
from
September 2, 2026 16:09
c98ba71 to
9795a2b
Compare
craigcomstock
marked this pull request as ready for review
September 2, 2026 16:09
Contributor
Author
|
@cf-bottom jenkins please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14623/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14623/ |
larsewi
reviewed
Sep 3, 2026
craigcomstock
force-pushed
the
ent-12599/master
branch
2 times, most recently
from
September 3, 2026 16:55
0b42a13 to
57b5998
Compare
Contributor
Author
|
Looks like pr-pipeline is not happy. I will debug and make sure this works in both cases: pr-pipeline and build-in-container. 👍 |
craigcomstock
marked this pull request as draft
September 3, 2026 17:08
craigcomstock
force-pushed
the
ent-12599/master
branch
3 times, most recently
from
September 3, 2026 21:56
f5a07bd to
d44af5b
Compare
Contributor
Author
|
Looking awesome in pr-pipeline and 🤞 for in-container build |
craigcomstock
marked this pull request as ready for review
September 3, 2026 22:01
…de the container Ticket: ENT-12599 Changelog: none
Ticket: ENT-12599 Changelog: None
craigcomstock
force-pushed
the
ent-12599/master
branch
2 times, most recently
from
September 4, 2026 16:29
8f34e8b to
420d0ce
Compare
Contributor
Author
|
bootstrap-mission-portal was being skipped due to ROLE != hub in bootstrap-pr jenkins job. I added a check for JOB_NAME=bootstrap-pr. |
The numbered steps are symlinks to existing scripts. The artifacts output directory had to be refactored slightly to work in both containers and regular build hosts. Some existing scripts were split up or refactored to migrate steps previously in build-in-container-inner.sh to build-script scripts. Ticket: ENT-12599 Changelog: None pull better mission portal bootstrap code from old bootstrap-tarballs
Ticket: None Changelog: None
Ticket: none Changelog: none
craigcomstock
force-pushed
the
ent-12599/master
branch
from
September 4, 2026 17:18
c207d01 to
14727ae
Compare
olehermanse
reviewed
Sep 4, 2026
Comment on lines
+31
to
+32
| # let setup-cfengine-build-host.sh know we are in a container and bootstrapping | ||
| RUN touch /etc/cfengine-in-container.flag |
Member
There was a problem hiding this comment.
WRT this flag file name, I'd maybe distinguish whether we're talking about building CFEngine in a container, or running CFEngine in a container. But no big deal of course.
Contributor
Author
There was a problem hiding this comment.
yeah, makes sense. would be easy to change :)
olehermanse
reviewed
Sep 4, 2026
olehermanse
approved these changes
Sep 4, 2026
olehermanse
reviewed
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.