Repository navigation
Conversation
github-project-automation
Bot
moved this to Backlog
in AI Detection GitHub Action Roadmap
b5904a5 to
6bc7377
Compare
Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
6bc7377 to
f532049
Compare
|
Code looks ok as a first pass, but I'd also want to find time to run this to validate it in more detail. |
andrew
left a comment
andrew
left a comment
There was a problem hiding this comment.
The history-loading phase still leaves long scans without progress output. Please cover that phase before merging.
| // ScanCommitRangeWithProgress scans all commits in the given range using the provided detectors, | ||
| // invoking progress after each commit is processed if non-nil. | ||
| func ScanCommitRangeWithProgress(repoPath, commitRange string, detectors []detection.Detector, progress ProgressFunc) (Report, error) { | ||
| commits, err := gitops.ListCommits(repoPath, commitRange) |
There was a problem hiding this comment.
ListCommits loads every commit and its notes before any progress callback runs. Running the CLI against a generated million-commit repository produced no stderr output for 51.8 seconds out of a 92.4-second scan, well beyond the ten-second threshold. Please add progress during history loading and a regression test through the CLI that covers a slow loading phase.
Report progress during history loading phase before scanning commits, and add CLI regression test covering slow loading. Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
Hey @andrew, I've pushed the updates to show progress during the history loading phase and added that regression test. Mind taking another look when you have a sec? |
…/show-scan-progress Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
3 participants
Description
Scanning commits: X/Y (Z%).--no-progressflag for CI use.This PR fixes #100
Notes for Reviewers
scanProgressDelayis avarso tests can override it.Signed commits
Generative AI disclosure
Please select one option: