You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Issue with demo npm-multiroot-react when using minimap plugin #548
Description:
While testing the minimap plugin in the npm-multiroot-react demo, I added the plugin to the editor config and set the element ID. However, I encountered an error, and all editors failed to load.
Steps to Reproduce:
Add the minimap plugin to editor config.
Set the container on the minimap config.
Run the demo.
Question:
Does the multi-root editor support the minimap plugin? Is there a missing configuration, or does the plugin need an update for multi-root support?
I've implemented a fix, but I'm uncertain about its overall impact because I'm unable to run the automated tests in my environment—Karma is throwing errors on the CKEditor5 test script, and I can't look into it at the moment.
To provide a better solution, I need guidance on detecting multi-root usage and dynamically changing the rootName based on the editor's focus.
Activity
Witoso commentedon Oct 21, 2024
Most likely this is the case, and the Minimap didn't get multiroot support. Do you remember @scofalik?
NikoEscobar commentedon Oct 21, 2024
@Witoso
Minimap currently doesn't support the multi-root editor.
https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-minimap/src/minimap.ts#L88
I've implemented a fix, but I'm uncertain about its overall impact because I'm unable to run the automated tests in my environment—Karma is throwing errors on the CKEditor5 test script, and I can't look into it at the moment.
To provide a better solution, I need guidance on detecting multi-root usage and dynamically changing the
rootNamebased on the editor's focus.