Repository navigation
fix(server): return error instead of panic in RegisterService validation - #2010
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
fix(server): RegisterService 参数校验失败时返回错误而非 panic
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
In server/server.go, RegisterService declares an error return signature but panicked on validation failures (when the server is running, when svcInfo is nil, when handler is nil, or when internal service registration fails).
This change updates RegisterService and generic service registration helpers (genericserver.RegisterService, genericserver.RegisterUnknownServiceOrMethodHandler) to return descriptive errors instead of panicking. It also introduces safe reflection-based nil checking so typed nil interface values and non-pointer handlers are handled without reflection panics. Comprehensive unit test assertions in server/server_test.go and server/genericserver/server_test.go verify all error paths.
(Optional) Which issue(s) this PR fixes:
Fixes #1981