Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Xcode 27,
app-store-connect publishreports a successful upload as failed.altoolnow writes a harmlessERROR:line before the success message:Altool._run_commandis meant to ignore logged errors when the upload succeeded, but it checks withre.match(".*UPLOAD SUCCEEDED.*", stdout).re.matchonly matches at the start of the string, and.doesn't match newlines, so the check only passes whenUPLOAD SUCCEEDEDis on the first line of the output. With this Xcode 27 output the command raisesAltoolCommandError("[ContentDelivery.Uploader...] Failed to create URL for 'CDUploaderStateInfoResumeFilePath'...")even though the build was delivered.This PR checks for
UPLOAD SUCCEEDEDanywhere in the output. Non-zero exit codes and parsed product errors are still handled first and still fail. Output that hasERROR:lines but no success message still fails as before.Changes:
src/codemagic/models/altool/altool.py: replace there.matchcheck with a substring check.tests/models/altool/mocks/mock_upload_success_with_error_log_stdout_xcode_27_2.txt: realaltool27.10.4 output from an upload that succeeded.tests/models/altool/test_altool.py: new test showing the upload succeeds. It fails without the fix. The new mock is also added to the parse test.uv run pytest tests/models/altool,ruff format --check,ruff checkandmypyall pass.