feat: add columnar-dbc Rust crates linking dbc statically by zeroshade · Pull Request #548 · columnar-tech/dbc

zeroshade · 2026-10-28T22:32:07Z

rust/: columnar-dbc (safe API), columnar-dbc-sys (bindgen 0.73.2 bindings generated from libdbc.h, committed) and five columnar-dbc-sys-<platform> crates, each bundling a prebuilt libdbc.a. Supported targets: x86_64/aarch64 Linux (glibc), x86_64/aarch64 macOS, x86_64-pc-windows-msvc and x86_64-pc-windows-gnu. Other targets fail at build time.

MSVC: a Go c-archive registers its runtime entry in .ctors, which only the MinGW CRT runs. Under MSVC the first dbc call blocked forever. The Windows platform crate registers _rt0_amd64_windows_lib in .CRT$XCU for target_env = "msvc". A local cargo xwin link map shows the pointer in the CRT's XCA..XCZ initializer table. CI in the top PR of the stack runs the tests.

Stacked on #547.

Linking libdbc

Modeled on zstd-sys, with pkg-config as the default. The source is chosen in this order:

DBC_SYS_LIB_DIR=<dir>: a custom directory.
DBC_SYS_USE_PKG_CONFIG set: pkg-config module dbc, even with bundled on.
The opt-in bundled feature: the per-platform prebuilt crates.
Otherwise (default): pkg-config module dbc.

By default the platform crates aren't downloaded at all; features = ["bundled"] opts into them. Env overrides win even when bundled is on: the platform crate is never extern crated, so its archive isn't linked. docs.rs builds with bundled since it has no installed libdbc.

Linking is static by default; DBC_DYNAMIC (pkg-config-rs's own convention) links libdbc.so. pkg-config-rs refuses static links for archives under /usr, so build.rs emits the link directives itself rather than using .statik(true).

The MSVC Go runtime initializer moved from the Windows platform crate into -sys. It's applied to any static x86_64 MSVC link, and static MSVC links on other architectures fail with a clear error.

…http tiny_http 0.12 unwraps peer_addr() on accept; on Windows it fails with WSAENOTCONN when the client has already closed the connection, killing the worker and failing the next request with EOF.

…LIB_DIR Keep bundled platform crates as the default, with custom-directory and pkg-config overrides selecting static or opt-in dynamic linking. Move the MSVC Go initializer into the sys crate and reject non-x86_64 static MSVC links. pkg-config 0.3.34 parse_libs defaults the non-macOS/non-Windows system root to /usr, and is_static_available requires an archive path outside every system root. Thus statik(true) alone emits an unqualified link for /usr/lib/<triplet>/libdbc.a, allowing the shared library to win. Probe without Cargo link metadata and explicitly emit static=dbc, leaving private system libraries dynamic.

The default build now locates an installed libdbc through the dbc pkg-config module. The prebuilt platform crates move behind the `bundled` feature, and the `pkg-config` feature is removed since it is now the default. DBC_SYS_LIB_DIR and DBC_SYS_USE_PKG_CONFIG keep their precedence over `bundled`.

amoeba

Generally I think this looks fine. I looked closer at some files than others and I expect I may have more review comments once this is all merged together.

amoeba · 2026-11-04T00:25:48Z

+```rust
+use columnar_dbc::{list_installed, Client, InstallLocation};
+
+let client = Client::new()?;


Suggested change

let client = Client::new()?;

// First create a Client

let client = Client::new()?;

amoeba · 2026-11-04T00:26:08Z

+use columnar_dbc::{list_installed, Client, InstallLocation};
+
+let client = Client::new()?;
+for d in client.search("postgres")?.drivers {


Suggested change

for d in client.search("postgres")?.drivers {

// Search for a driver using a pattern

for d in client.search("postgres")?.drivers {

amoeba · 2026-11-04T00:27:01Z

+    println!("{} - {}", d.path, d.description);
+}
+
+// Into dbc's user-level location, like `dbc install -l user` ...


Suggested change

// Into dbc's user-level location, like `dbc install -l user` ...

// Install a driver to the user level install location. Same behavior as `dbc install -l user`.

amoeba · 2026-11-04T00:29:00Z

+}
+
+// Into dbc's user-level location, like `dbc install -l user` ...
+let manifest = client.install("postgresql", &InstallLocation::User)?;


Hrm.... So I think the C API and therefore Rust require an explicit install location. I'm now wondering whether we can have bindings for install behave more like the CLI. I think the ideal code here would be,

let driver = client.install("postgresql")?;

amoeba · 2026-11-04T00:32:18Z

+let dir = InstallLocation::Directory("/opt/adbc/drivers".into());
+client.install("postgresql", &dir)?;
+assert_eq!(list_installed(&dir)?.len(), 1);
+# Ok::<(), columnar_dbc::Error>(())


What is this line doing? If this was supposed to be a doctest, I don't think the README is hooked up yet. May as well. I guess you can add this to lib.rs,

#![doc = include_str!("../README.md")]

and fence the codeblock with ````rust,no_run`.

amoeba · 2026-11-04T00:33:02Z

+`install` verifies each driver's signature with Columnar's key and removes a
+driver that fails. For drivers from a trusted private registry,


Suggested change

`install` verifies each driver's signature with Columnar's key and removes a

driver that fails. For drivers from a trusted private registry,

`install` verifies each driver's signature with Columnar's public signing key and cleans up a

driver that fails verification. For drivers from a trusted private registry,

amoeba · 2026-11-04T00:37:06Z

+    User,
+    /// dbc's system-level location, as `dbc install -l system`; usually needs
+    /// elevated privileges.
+    System,


Same comment as in earlier PRs. dbc's config.ConfigLevel is System|User|Env. I'm not sure if it matters to align.

amoeba · 2026-11-04T00:41:52Z

+
+#[derive(Debug, Clone)]
+#[non_exhaustive]
+pub struct Driver {


Should this struct be missing the other fields in the registry index like urls, docs_url, pkginfo, and an association to a registry so we can disambiguate drivers with the same path on multiple registries?

amoeba · 2026-11-04T00:49:46Z

+let manifest = client.install("postgresql", &InstallLocation::User)?;
+println!("installed {} {} at {}", manifest.id, manifest.version, manifest.driver_path);
+
+// ... or into an explicit directory.


Suggested change

// ... or into an explicit directory.

// You can also install the driver to a specific directory.

I don't really like how these PR stacks are exposing this new way of installing drivers. The old way was to set ADBC_DRIVER_PATH before doing things and now we have two ways.

zeroshade mentioned this pull request Oct 28, 2026

build: release the C API and columnar-dbc crates with GoReleaser #549

Open

zeroshade temporarily deployed to snapshot October 28, 2026 22:32 — with GitHub Actions Inactive

zeroshade added this pull request to stack #550 October 28, 2026 22:46

zeroshade force-pushed the feat/rust-crates branch from 352affc to 9fa4004 Compare October 28, 2026 22:51

zeroshade temporarily deployed to snapshot October 28, 2026 22:51 — with GitHub Actions Inactive

zeroshade force-pushed the feat/rust-crates branch from 9fa4004 to c136c8b Compare October 28, 2026 23:29

zeroshade temporarily deployed to snapshot October 28, 2026 23:29 — with GitHub Actions Inactive

zeroshade temporarily deployed to snapshot October 28, 2026 23:45 — with GitHub Actions Inactive

zeroshade force-pushed the feat/rust-crates branch from 9239767 to 99c1202 Compare October 29, 2026 17:07

zeroshade temporarily deployed to snapshot October 29, 2026 17:07 — with GitHub Actions Inactive

zeroshade temporarily deployed to snapshot October 30, 2026 15:55 — with GitHub Actions Inactive

zeroshade temporarily deployed to snapshot November 3, 2026 18:07 — with GitHub Actions Inactive

zeroshade added 5 commits November 3, 2026 13:15

feat: add columnar-dbc Rust crates linking dbc statically

472e55c

fix(rust): start the Go runtime under the MSVC CRT

6958aea

test(rust): serve the fixture registry with std::net instead of tiny_…

b1693ee

…http tiny_http 0.12 unwraps peer_addr() on accept; on Windows it fails with WSAENOTCONN when the client has already closed the connection, killing the worker and failing the next request with EOF.

zeroshade force-pushed the feat/rust-crates branch from d200703 to e74846d Compare November 3, 2026 18:21

zeroshade temporarily deployed to snapshot November 3, 2026 18:21 — with GitHub Actions Inactive

zeroshade marked this pull request as ready for review November 3, 2026 19:27

amoeba approved these changes Nov 4, 2026

View reviewed changes

Navigation Menu

Repository navigation

feat: add columnar-dbc Rust crates linking dbc statically - #548

feat: add columnar-dbc Rust crates linking dbc statically#548
zeroshade wants to merge 5 commits into
feat/capifrom
feat/rust-crates

zeroshade commented Oct 28, 2026 •

edited

Loading

Uh oh!

amoeba left a comment

Uh oh!

amoeba Nov 4, 2026

Uh oh!

amoeba Nov 4, 2026

Uh oh!

amoeba Nov 4, 2026

Uh oh!

amoeba Nov 4, 2026

Uh oh!

amoeba Nov 4, 2026

Uh oh!

amoeba Nov 4, 2026

Uh oh!

amoeba Nov 4, 2026

Uh oh!

amoeba Nov 4, 2026

Uh oh!

amoeba Nov 4, 2026

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	let client = Client::new()?;
	// First create a Client
	let client = Client::new()?;

	// Into dbc's user-level location, like `dbc install -l user` ...
	// Install a driver to the user level install location. Same behavior as `dbc install -l user`.

		`install` verifies each driver's signature with Columnar's key and removes a
		driver that fails. For drivers from a trusted private registry,

	// ... or into an explicit directory.
	// You can also install the driver to a specific directory.

Conversation

zeroshade commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linking libdbc

Uh oh!

amoeba left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zeroshade commented Oct 28, 2026 •

edited

Loading