Skip to content

chore(release): release-prepare counts the pull requests merged into a milestone branch - #198

Merged
pviti merged 2 commits into
milestone/nextfrom
chore/release-milestone-branch
Nov 6, 2026
Merged

pviti merged 2 commits into
milestone/nextfrom
chore/release-milestone-branch

Conversation

@pviti

@pviti pviti commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Change pull requests now target the milestone branch milestone/next (milestone "Next release") instead of main. The developer merges into it only what is meant to ship, and its single pull request into main is the release, so one approval covers the whole milestone.

What changes in bin/release-prepare. Run on a milestone branch, it now takes the version and the notes from the pull requests merged into that branch (its first-parent history above main), together with what main holds since the last tag.

  • The milestone pull request's own title does not count.
  • A feature branch with no pull requests merged into it behaves as before: its own title counts.
  • Merges of main into the branch and the release bump commit are left out.

The README "Releasing" section describes the flow.

Tests. bin/release-prepare-test gains 7 milestone checks:

  • the bump comes from the merged feat;
  • both merged pull requests appear in the notes;
  • the branch's own title is not a change;
  • a real run updates the pull request;
  • a re-run does not bump again;
  • the bump commit stays out of the notes.

The whole harness passes.

Not a release.

🤖 Generated with Claude Code

…a milestone branch

Change pull requests target a milestone branch (release/next) instead of main;
its one pull request into main is the release, so one approval covers the
milestone. On that branch, release-prepare now takes the version and the notes
from the pull requests merged into it (plus main since the last tag); the
branch's own pull request title counts only on a feature branch with none.
README describes the flow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pviti pviti added this to the Next release milestone Nov 6, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pviti
pviti merged commit 0c2fcd9 into milestone/next Nov 6, 2026
1 check passed
@pviti
pviti deleted the chore/release-milestone-branch branch November 6, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant