Skip to content

Align structural geometry typing contracts - #1539

Closed
tomvanmele wants to merge 23 commits into
initiative/repository-modernisationfrom
initiative/typing-alignment
Closed

tomvanmele wants to merge 23 commits into
initiative/repository-modernisationfrom
initiative/typing-alignment

Conversation

@tomvanmele

Copy link
Copy Markdown
Member

Summary

  • introduce structural triangle-mesh input typing with NumPy-compatible boundaries
  • migrate Boolean, intersection, remeshing, triangulation, and libigl-backed plugin contracts
  • retain verified Gaussian angle-defect curvature and remove unsupported mean/principal core contracts
  • remove the obsolete tessellation plugin decorator infrastructure

Verification

  • 2116 tests pass
  • Pyright reports 0 errors
  • Ruff check and format check pass
  • strict MkDocs build passes

Coordination

This draft targets the verified repository-modernisation branch so the review contains only the typing and approved geometry-contract changes. It remains isolated from main.

@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.78470% with 65 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (initiative/repository-modernisation@f3f8dba). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/compas/geometry/polyhedron.py 67.50% 13 Missing ⚠️
src/compas/geometry/triangulation_delaunay.py 89.76% 13 Missing ⚠️
src/compas/geometry/triangulation.py 91.85% 11 Missing ⚠️
src/compas/geometry/_core/transformations.py 83.33% 7 Missing ⚠️
src/compas/geometry/_core/distance.py 86.66% 4 Missing ⚠️
src/compas/geometry/booleans.py 81.81% 4 Missing ⚠️
src/compas/geometry/shapes/shape.py 88.88% 3 Missing ⚠️
src/compas/geometry/polygonal_surface.py 93.10% 2 Missing ⚠️
src/compas/geometry/surfaces/surface.py 87.50% 2 Missing ⚠️
src/compas/geometry/trimesh/parametrisation.py 84.61% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@                          Coverage Diff                           @@
##             initiative/repository-modernisation    #1539   +/-   ##
======================================================================
  Coverage                                       ?   85.82%           
======================================================================
  Files                                          ?      220           
  Lines                                          ?    23904           
  Branches                                       ?        0           
======================================================================
  Hits                                           ?    20515           
  Misses                                         ?     3389           
  Partials                                       ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomvanmele

Copy link
Copy Markdown
Member Author

Completed by fast-forwarding to exact head . GitHub cannot retarget this draft after integration because the base now contains every head commit.

@tomvanmele tomvanmele closed this Nov 7, 2026
@tomvanmele

Copy link
Copy Markdown
Member Author

Correction to the closure record: this initiative was completed by
fast-forwarding remove-future to exact head
99b82a6673ff7d05c1c323c8921135c274993f11. GitHub could not retarget the
draft after integration because the base already contained every head commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant