-
Notifications
You must be signed in to change notification settings - Fork 0
Add the chrome primitives the new toolbars are built on #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AndrewG828
wants to merge
1
commit into
user/andrewgao/feature/UI-UX-Lucid-Refactor
Choose a base branch
from
user/andrewgao/feature/UI-UX-Lucid-Refactor-02-chrome-primitives
base: user/andrewgao/feature/UI-UX-Lucid-Refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| // | ||
| // GlassToolbarModifier.swift | ||
| // Resell | ||
| // | ||
| // Created by Andrew Gao on 9/3/26. | ||
| // | ||
|
|
||
| import SwiftUI | ||
|
|
||
| /// Liquid Glass background for the floating toolbar controls that sit over a | ||
| /// scrolling feed (search pill, filter button, notification button). | ||
| /// | ||
| /// The near-clear fill and explicit `contentShape` are load-bearing: neither | ||
| /// `glassEffect` nor `Material` alone claims the whole pill for hit testing, so | ||
| /// taps near the edge of a control would fall through to the content behind it. | ||
| struct GlassToolbarModifier: ViewModifier { | ||
|
|
||
| var cornerRadius: CGFloat = 999 | ||
| /// Opaque enough to keep foreground text legible over busy content. | ||
| var isOpaque: Bool = false | ||
|
|
||
| func body(content: Content) -> some View { | ||
| let shape = RoundedRectangle(cornerRadius: cornerRadius, style: .continuous) | ||
| if #available(iOS 26, *) { | ||
| content | ||
| .background { shape.fill(Color.white.opacity(isOpaque ? 0.55 : 0.001)) } | ||
| .contentShape(shape) | ||
| .glassEffect(.regular, in: shape) | ||
| } else { | ||
| content | ||
| .background { shape.fill(Color.white.opacity(0.001)) } | ||
| .contentShape(shape) | ||
| .background( | ||
| isOpaque ? AnyShapeStyle(.regularMaterial) : AnyShapeStyle(.ultraThinMaterial), | ||
| in: shape | ||
| ) | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should put a modifier file into a diff direc maybe like "custom" or "modifier"