Repository navigation
fix(core): report parents that local writes restore - #287
Open
marcus-pousette wants to merge 2 commits into
Open
marcus-pousette wants to merge 2 commits into
marcus-pousette wants to merge 2 commits into
Conversation
A local write under a deleted parent, such as a payload on its child, restores the parent when the delete didn't know about the write. commit_local refreshed the tombstones but dropped what changed, so finalize found nothing to report: onMaterialized listed only the written node and changedSince missed the parent, while peers applying the same op also reported the restored parent. Local plans now carry those changes, except a local delete's own node, which the plan already reports.
marcus-pousette
force-pushed
the
fix/local-restore-events
branch
from
November 2, 2026 11:41
61b6afd to
49294a7
Compare
marcus-pousette
marked this pull request as ready for review
November 2, 2026 13:59
The tree already showed the restored parent before the fix. The event and changedSince checks are what fail without it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A local write under a deleted parent, such as a payload on its child or an insert under it, restores the parent when the delete didn't know about that write. The tree state was already right, but
onMaterializedreported only the written node, while peers applying the same op also reported the parent's restore.commit_localrefreshed the tombstones and dropped what changed, sofinalize_local_with_outcomefound nothing left to report. Local plans now carry those changes, except a local delete's own node, which the plan already reports.changedSince(#281) missed the restored parent for the same reason. The new conformance scenario checks that too, on the engines that havechangedSince.