Repository navigation
fix(sqlite-ext): read the SQLite API table by slot - #293
Open
Antonov548 wants to merge 3 commits into
Open
Antonov548 wants to merge 3 commits into
Antonov548 wants to merge 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
bindgen 0.60 turns sqlite3_api_routines opaque when libclang cannot lay out va_list, so the extension cannot use the generated fields. Co-authored-by: Cursor <cursoragent@cursor.com>
Playwright 1.57 has no Chromium build for the Ubuntu 26.04 image that ubuntu-latest now uses. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainSQLite extension build.sqlite3_api_routinesby the stable function-pointer order, because bindgen 0.60 turns that struct opaque on the CI libclang.Test plan
cargo test -p treecrdt-sqlite-ext --test extension_roundtrip --features ext-sqliteMade with Cursor