[+] add SECURITY.md and CONTRIBUTING.md, fix the service unit - #428
Open
pashagolub wants to merge 2 commits into
Open
pashagolub wants to merge 2 commits into
pashagolub wants to merge 2 commits into
Conversation
* SECURITY.md: vip-manager runs as root, opens raw sockets and holds DCS and Hetzner API credentials, so it should say where to report a finding instead of having it end up in the public issue tracker. Reporting goes through GitHub's private advisories, no new mailbox needed. * CONTRIBUTING.md: how to build, test and lint, which tests are skipped without Docker or root, and the commit subject convention of this repository. * vip-manager.service: After=network-online.target does not pull the target in on its own, the unit needs a Wants= for the ordering to have any effect. * README: the prerequisite said go >= 1.19 while go.mod asks for 1.26. * gofmt over two test files that were left with trailing whitespace.
Embedding both the configuration and the etcd client put their methods and fields into one namespace: elc.Get() and elc.Close() silently belonged to the client, elc.Logger to the configuration, and any name the two come to share in a future release of either would break the build far away from the cause. The tests reached through the same promotion, which is how a test ended up calling the Close() of the client. No behaviour change. The consul and the patroni checker embed their client the same way and can follow if this direction is welcome.
pashagolub
force-pushed
the
chore/project-hygiene
branch
from
September 14, 2026 15:24
312ec80 to
e1b5cf5
Compare
|
coverage: 92.075% (-0.08%) from 92.15% — chore/project-hygiene into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SECURITY.md: vip-manager runs as root, opens raw sockets and holds DCS and
Hetzner API credentials, so it should say where to report a finding instead
of having it end up in the public issue tracker. Reporting goes through
GitHub's private advisories, no new mailbox needed.
CONTRIBUTING.md: how to build, test and lint, which tests are skipped
without Docker or root, and the commit subject convention of this
repository.
vip-manager.service: After=network-online.target does not pull the target
in on its own, the unit needs a Wants= for the ordering to have any effect.
README: the prerequisite said go >= 1.19 while go.mod asks for 1.26.
gofmt over two test files that were left with trailing whitespace.