Skip to content

Fix duplicate IPSLA counts in post-upgrade callback check - #478

Merged
monrog2 merged 2 commits into
v4.3.0-devfrom
codex/issue-344-ipsla-unique-dns
Oct 2, 2026
Merged

monrog2 merged 2 commits into
v4.3.0-devfrom
codex/issue-344-ipsla-unique-dns

Conversation

@monrog2

@monrog2 monrog2 commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Duplicate IPSLA objects with the same DN can make Post Upgrade Callback Integrity report an outage even when the old and converted policy counts match. For example, issue #344 reports a count of two fvSlaDef objects while the listing contains one policy.

Query fvSlaDef and fvIPSLAMonitoringPol directly and compare their unique DN counts after all pages are retrieved. This also handles duplicates in plain class responses. Genuine count mismatches still produce FAIL - OUTAGE WARNING!!; the other callback checks, version gates, and query error handling retain their existing behavior.

Add synthetic fixtures and regressions for duplicates in either class, duplicates across pages, missing objects masked by duplicates, extra objects, empty classes, same-name policies in different tenants, malformed objects, API errors, and incomplete responses.

Validation:

  • Focused callback and icurl tests: 39 passed.
  • Full unit suite on Python 3.9.6: 1,433 passed.
  • Python 3.8 syntax parsing and git diff --check: passed.
  • Python 2.7 and 3.8 runtime testing remains for CI; those interpreters are unavailable locally.

Related defect: CSCwt30743.

Fixes #344.

@monrog2
monrog2 merged commit 682c24f into v4.3.0-dev Oct 2, 2026
3 checks passed
@monrog2
monrog2 deleted the codex/issue-344-ipsla-unique-dns branch October 5, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive fault raised for "[Check 12/89] Post Upgrade Callback Integrity"

1 participant