Repository navigation
Fix duplicate IPSLA counts in post-upgrade callback check - #478
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicate IPSLA objects with the same DN can make Post Upgrade Callback Integrity report an outage even when the old and converted policy counts match. For example, issue #344 reports a count of two
fvSlaDefobjects while the listing contains one policy.Query
fvSlaDefandfvIPSLAMonitoringPoldirectly and compare their unique DN counts after all pages are retrieved. This also handles duplicates in plain class responses. Genuine count mismatches still produceFAIL - OUTAGE WARNING!!; the other callback checks, version gates, and query error handling retain their existing behavior.Add synthetic fixtures and regressions for duplicates in either class, duplicates across pages, missing objects masked by duplicates, extra objects, empty classes, same-name policies in different tenants, malformed objects, API errors, and incomplete responses.
Validation:
icurltests: 39 passed.git diff --check: passed.Related defect: CSCwt30743.
Fixes #344.