Repository navigation
0.33.4: cap sqlglot <30.18 so scans work on fresh installs, clear lockfile CVEs - #118
Merged
Merged
Conversation
…kfile CVEs ibis 12.0.0 drops the view backing an in-memory create_table with a raw string passed to sge.Drop; sqlglot 30.18 stopped coercing it, so the statement renders as a nameless `DROP VIEW IF EXISTS` and DuckDB raises ParserException. ibis 12.0.0 puts no upper bound on sqlglot, so any fresh install on Python >= 3.10 resolves ibis 12.0.0 + sqlglot 30.21 and breaks Excel/ODS, Iceberg and partitioned-Parquet scans. Fixed upstream in ibis-project/ibis#12104 but not released yet (ibis-project/ibis#12124), so cap sqlglot below 30.18 (the pin ibis maintainers proposed themselves) until an ibis release ships the fix. CI only caught it on the 3.10-lowest leg, whose `uv run` re-resolves to the newest versions; the 3.14 leg uses the lock (ibis 11) and never saw it. Refresh the lockfile to clear the advisories failing the CI audit: fsspec 2026.2.0 -> 2026.9.0 (CVE-2026-104851; s3fs/gcsfs/adlfs pin fsspec exactly, so they move with it), multidict 6.7.1 -> 6.9.1 (CVE-2026-104874), and pyjwt 2.13.0 -> 2.15.1, superseding Dependabot's #117. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…3.13.16+
Database tests built `sqlite:////{tmp_path}`, the POSIX-only absolute form.
On Windows it yields the path `\C:\Users\...`, which only worked because
ntpath.realpath used to rebuild paths with ntpath.join, whose drive
semantics silently dropped the current drive (`D:\` + `C:\...` -> `C:\...`).
CPython 3.13.16 joins by plain concatenation instead, so Path.resolve()
now returns `D:\C:\Users\...` and stat() fails with WinError 123 (the
WinError 32 teardown errors follow from the database left open).
Use `sqlite:///{path.as_posix()}` like the other tests, matching the
documented form and the URL add_database builds itself. The URL is
unchanged on POSIX, and on Windows it becomes `sqlite:///C:/...`.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParserException: syntax error at end of input. Capsqlglot<30.18until ibis ships the upstream fix. Bumps to 0.33.4 so the fix reaches PyPI.Root cause 1: ibis 12 + sqlglot ≥ 30.18
ibis 12.0.0 drops the view behind an in-memory
create_tableby passing a raw string tosge.Drop. sqlglot 30.18 (2026-09-03) stopped coercing that string, so the SQL becomes a namelessDROP VIEW IF EXISTSand DuckDB rejects it. ibis 12.0.0 puts no upper bound on sqlglot, so any fresh resolution gets ibis 12.0.0 + sqlglot 30.21.Why CI only failed on 3.10-lowest: that job's
make test(uv run) re-resolves to the newest versions afteruv sync --resolution lowest, so it is the only leg that saw ibis 12. The 3.14 leg uses the lock (ibis 11), and 3.9 cannot install ibis 12.Root cause 2: Windows leg and Python 3.13.16
Database tests built
sqlite:////{tmp_path}, the POSIX-only absolute form, which gives the path\C:\Users\…on Windows.ntpath.realpathrebuilt paths withntpath.join, whose drive semantics silently dropped the current drive (D:\+C:\…→C:\…).Path.resolve()returnsD:\C:\Users\…andstat()fails with WinError 123. The WinError 32 teardown errors follow from the database left open.Tests now use
sqlite:///{path.as_posix()}, liketests/test_incremental_database.py. This is also the documented form and the URLadd_databasebuilds itself. The URL is unchanged on POSIX.Changes
pyproject.toml: add"sqlglot<30.18", with a comment saying when to drop it. Version 0.33.4.CHANGELOG.md: 0.33.4 entry.uv.lock: targeted upgrades only:tests/database/test_{sqlite,db_introspect,geopackage}.py: portable SQLite URLs (37 lines).Verification (local, replaying CI commands)
sqlite:///C:/…simulated → absoluteC:/…path. This PR's CI is the end-to-end checkNotes
test_read_statistical_mixed_typesfails because it assertsdtype == objectand pandas 3 infersstr. The test is too strict; the package behaves correctly. No current CI leg resolves pandas 3.🤖 Generated with Claude Code