feat: Add plugin logs, metrics, and location labels - #305
Merged
Merged
Conversation
Workloads and instances stamped Location resource names; resolve them through the project Locations catalog so lists and detail pages show city and country. Mirror logs and metrics onto the staff-portal plugin, keep the consumer overview on KPI previews, and share react/jsx-runtime so the remote loads in the host.
mattdjenkinson
requested review from
kevwilliams,
savme and
scotwells
and removed request for
kevwilliams
September 14, 2026 11:30
Keep cloud-portal's react 19.3 / react-router 8 pins so the consumer plugin still shares the host singletons, and keep recharts for metrics.
kevwilliams
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compute portal plugins showed raw Location resource names (
loc-dfw-1,DFW) and the staff-portal plugin had no logs or metrics. This wires Prometheus and Loki the same way on both plugins, and resolves stamped location names through the projectlocations.miloapis.comcatalog so tables and cards show place names like "Ashburn, US".Key behaviors:
react/jsx-runtimeso staff-portal can load the containerTest plan
bun run build && bun run previewinui/provider, register withPORTAL_PLUGINS_JSONincludingserviceRef.name=compute/admin/service-catalog/computeWorkloads tab shows enriched location columnCardFieldexists (2.5.0 made DetailList crash)Notes for reviewers
Staff-portal must share
react/jsx-runtimefrom the host (same pattern asreact-dom/client) or the plugin fails at container load. Local staff-portal also needs datum-ui 2.9.1 forCardField; that bump is not in this PR.