Repository navigation
Rework changes detection; Implement tests for renames - #188
Conversation
When object has 'renamed_from' property, but the previous version does not exists, the warning should be issued and for this object CREATE XXX query should be generated.
Fixes: 185 GitHub: dbsrgits#185
0575de1 to
9ddf601
Compare
|
Also fixes this: jjn1056/DBIx-Class-Migration#129 |
63d26ac to
f9e50ba
Compare
Eg. SRC:x, DST:y:rx, DST:x
Renames should go first, otherwise it could not be possible to add a new column with the name which was just renamed to something. Eg. SRC:x->DST:y, Create DST:x. Otherwise we can not run 'Create DST:x', because schema still have 'x' column.
f9e50ba to
fd58e13
Compare
rabbiveesh
left a comment
rabbiveesh
left a comment
There was a problem hiding this comment.
apologies on the slow turnaround; out of perl now and just started a new $job, but i'll see if i can squeeze this in.
Trying to understand the full intent + then i can dig into more
There was a problem hiding this comment.
the tests here have nothing to do with the rest of the producer behaviors, could you just put this in a new diff test which produces yaml?
There was a problem hiding this comment.
Btw it was done few month ago.
|
Intention in this PR is to fix bugs, generalize code and extend tests. |
matthewpersico
left a comment
matthewpersico
left a comment
There was a problem hiding this comment.
So sorry this fell off the table.
rabbiveesh
left a comment
rabbiveesh
left a comment
There was a problem hiding this comment.
I've settled on names, and then i have comments about the $skip bit in the table field diff
|
@rabbiveesh done. Once merged, I'll create follow up PR. |
rabbiveesh
left a comment
rabbiveesh
left a comment
There was a problem hiding this comment.
grand! thanks so much for your work (sorry that it took so long)
|
@rabbiveesh No worries, I am happy this was merged. May we cooperate for the next improvements? |
|
Sure, hit me up on discord. |
3 participants
In this PR we:
renamesworkflows.Now function could be easily reused for different types of objects
This happens when we want to drop the old object and give the name of dropped object to another one.
This changes are related to #184