Repository navigation
provider.go: Allow pausing admission - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acceptingPlayers currently only goes false on Close(), which also closes every established connection. That makes it impossible to drain a host during a rolling update, where you want to stop new joins but keep current players connected.
Pause() reports acceptingPlayers: false and refuses new stateless, assisted and diagnostic admissions. Established connections and admissions already in progress are not affected. Resume() reverts that. Close and Deregister now stop admission through the same gate, so Resume can't reopen it during shutdown.
The provider sees the change with the next heartbeat, so the minimum update interval still applies. This follows the spec: "Report acceptingPlayers: false to pause admission ... Keep reporting actual remaining players."
Tested in TestPause, TestPauseDiagnostics and TestAssistedJoin.