Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verifier closure captured the admission key and go-nethernet keeps that closure on the Conn, so the key stayed in memory for the whole session even though it's only needed for the one identity check at login.
The key now lives on the attempt and is released once the login is verified, its deadline passes, setup fails, the game reports an outcome or the connection closes. A verification after release fails with "admission no longer pending", the deadline case keeps "admission expired before login".
This follows the binding lifecycle in the wire reference: "Retain the actual admitted key epoch until comparison, channel closure, rejection or the ticket's login deadline."
Tested in TestVerifierReleasesKey.