Skip to content

host.go: Release pending login bindings - #2

Closed
EinBexiii wants to merge 1 commit into
df-mc:mainfrom
EinBexiii:feature/pending-bindings
Closed

EinBexiii wants to merge 1 commit into
df-mc:mainfrom
EinBexiii:feature/pending-bindings

Conversation

@EinBexiii

Copy link
Copy Markdown
Contributor

The verifier closure captured the admission key and go-nethernet keeps that closure on the Conn, so the key stayed in memory for the whole session even though it's only needed for the one identity check at login.

The key now lives on the attempt and is released once the login is verified, its deadline passes, setup fails, the game reports an outcome or the connection closes. A verification after release fails with "admission no longer pending", the deadline case keeps "admission expired before login".

This follows the binding lifecycle in the wire reference: "Retain the actual admitted key epoch until comparison, channel closure, rejection or the ticket's login deadline."

Tested in TestVerifierReleasesKey.

@EinBexiii EinBexiii closed this Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant