Repository navigation
Conversation
The verification reports attach work-product documents to a component (or feature) when its title slug occurs in the document ID. A short slug that prefixes sibling slugs therefore also collected the siblings' documents, e.g. component "Time" listed doc__time_daemon_* and doc__time_slave_* next to its own doc__time_* documents. workproduct_rows now takes the titles of all elements in the report and excludes documents that match a longer sibling slug, so the longest match wins. Callers without sibling titles keep the old behaviour. Signed-off-by: Anton Krivoborodov <anton.krivoborodov@bmw.de>
The new {% set %} lines for the sibling titles emitted extra blank lines
into the rendered report, which changed the checked-in expected needs.json
of the reference_integration/modern_module scenario. Trim the surrounding
whitespace so the output only differs where a longer sibling slug exists.
Signed-off-by: Anton Krivoborodov <anton.krivoborodov@bmw.de>
Contributor
|
Documentation preview for this pull request is available at: |
antonkri
marked this pull request as ready for review
November 5, 2026 10:08
antonkri
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
November 5, 2026 10:08
Member
|
lets abandon slug matching completely by finalizing #940 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The module/platform verification reports attach work-product documents (requirements/architecture/
implementation inspection, DFA, FMEA) to a component or feature by checking whether its title slug
occurs in the document ID (
_WorkproductRows). A short slug that is contained in sibling slugstherefore also collects the siblings' documents.
Seen in the time module report (eclipse-score/time#301): the component Time (slug
time) listeddoc__time_req_inspection,doc__time_daemon_req_inspectionanddoc__time_slave_req_inspectionfor every work product, because
timeis contained intimedaemonandtimeslave.Fix (minimal)
workproduct_rowsgets an optionalsibling_titlesargument with the titles of all elements of thereport (all components of the module / all features of the platform report). A document that also
matches a longer sibling slug is excluded, i.e. the longest match wins. The exclusion is emitted
directly into the needtable filter (
and "timedaemon" not in id...), no metamodel change.Calls without
sibling_titlesbehave exactly as before.Verification
test_workproduct_rows_leave_documents_to_longer_sibling_slug;bazel test //src/extensions/score_sphinx_needs_templates/...passes (incl. the platform reportrendering test).
--override_module=score_docs_as_code=<this branch>.The Time section now only lists
doc__time_*, Time Daemon / Time Slave unchanged.Not in scope
The slug is still derived from the component title, so a component whose title does not match its
document IDs (e.g. "Time Sync Client" vs.
doc__ts_client_*) still shows no documents. That wouldneed a separate change (e.g. slug from the component ID or an explicit link).