Repository navigation
feat(metamodel): add optional document.belongs_to links - #942
Draft
AlexanderLanin wants to merge 2 commits into
Draft
AlexanderLanin wants to merge 2 commits into
AlexanderLanin wants to merge 2 commits into
Conversation
Contributor
|
Decision in the process meeting was to go for Judging from the requirements, we don't need |
Member
Author
|
Still required AFAIK, but I do not have any kind of overview. |
antonkri
added a commit
that referenced
this pull request
Oct 13, 2026
…eports" This reverts commit d2ed665 (#941) and so restores #933. #941 reverted the change because the process plan was read as mandating the generic `document` type (#940). That reading has since been clarified: the dedicated `mod_ver_report` type is the intended model, so the original change applies again. Superseding #942, which added `belongs_to` to `document` instead. Note that #942 only extended the metamodel; nothing read the new link, so the report still derived its module by parsing the report id. Two changes on top of the original #933: - Version scoping reuses the existing optional `applies_to_module_version` attribute of `mod_ver_report` instead of introducing a second, near-identical `report_version` attribute. `document.report_version` stays as it is, it still scopes the platform verification report. - The file-based test for `tool_req__docs_verification_report_need` now fully verifies the requirement, with one case per statement, instead of partially verifying it.
antonkri
added a commit
that referenced
this pull request
Oct 13, 2026
…eports" This reverts commit d2ed665 (#941) and so restores #933. the generic `document` type (#940). That reading has since been clarified: the dedicated `mod_ver_report` type is the intended model, so the original change applies again. Superseding #942, which added `belongs_to` to `document` instead. Note that #942 only extended the metamodel; nothing read the new link, so the report still derived its module by parsing the report id. Two changes on top of the original #933: - Version scoping reuses the existing optional `applies_to_module_version` attribute of `mod_ver_report` instead of introducing a second, near-identical `report_version` attribute. `document.report_version` stays as it is, it still scopes the platform verification report. - The file-based test for `tool_req__docs_verification_report_need` now fully verifies the requirement, with one case per statement, instead of partially verifying it.
a-zw
pushed a commit
that referenced
this pull request
Oct 13, 2026
) This reverts commit d2ed665 (#941) and so restores #933. the generic `document` type (#940). That reading has since been clarified: the dedicated `mod_ver_report` type is the intended model, so the original change applies again. Superseding #942, which added `belongs_to` to `document` instead. Note that #942 only extended the metamodel; nothing read the new link, so the report still derived its module by parsing the report id. Two changes on top of the original #933: - Version scoping reuses the existing optional `applies_to_module_version` attribute of `mod_ver_report` instead of introducing a second, near-identical `report_version` attribute. `document.report_version` stays as it is, it still scopes the platform verification report. - The file-based test for `tool_req__docs_verification_report_need` now fully verifies the requirement, with one case per statement, instead of partially verifying it.
AlexanderLanin
added a commit
that referenced
this pull request
Oct 16, 2026
Contributor
|
Documentation preview for this pull request is available at: |
AlexanderLanin
commented
Oct 16, 2026
Comment on lines
+77
to
+79
| Generic Documents (`document`) may optionally link with `belongs_to` to the | ||
| Module (`mod`), Component (`comp`), or Feature (`feat`) they document. The link | ||
| can be omitted when the document has no such owner. |
Member
Author
There was a problem hiding this comment.
does not belong here. This document only described the schema, not a concrete metamodel
AlexanderLanin
force-pushed
the
steward/eclipse-score-docs-as-code/work-8f649e008a76
branch
from
November 5, 2026 14:07
b4c389e to
71ddebd
Compare
a-zw
requested changes
Nov 5, 2026
|
|
||
| .. test_metadata:: Document and TVR Attribute Validation | ||
| :id: test_metadata__doc_tool_attrs | ||
| :fully_verifies_list: tool_req__docs_doc_generic_mandatory,tool_req__docs_tvr_safety,tool_req__docs_tvr_security,tool_req__docs_tvr_status,tool_req__docs_tvr_confidence_level |
Contributor
There was a problem hiding this comment.
Extend tool_req__docs_doc_generic_mandatory accordingly. I assume this will become mandatory eventually.
Member
Author
There was a problem hiding this comment.
its not mandatory right now. we can create a new _optional requirement I guess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Generic documents need a way to identify the module, component, or feature they document, as agreed in the meeting decision. Documents without such an owner can continue to omit the link.
Add optional
document.belongs_tolinks restricted tomod,comp, andfeat, and document the allowed targets and omission semantics. Regression coverage accepts all three target types, rejects a work-product target, and retains the existing document without an ownership link.Closes #940
AI analyzed #940 and selected it for automated implementation. This PR is the result of that implementation.