Recreate the video encoder session at the adaptive resolution after a restart - #488
Open
gabbelitoV2 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startRunningsetinvalidateSessionbut keptoldBitrateVideoSize. With adaptive resolution active and the bitrate below a threshold, the first frame after a reconnect skipped the adaptive branch (same size as before) and the invalidate branch created the session at full resolution, so the encoder ran full size at the low bitrate until the bitrate crossed another threshold. Resetting the size on start makes the first frame create the session at the adaptive size and notify the control delegate.Not built locally, relying on CI for the build.